Repository navigation
fix(ci): quote the labeler trigger's echo so YAML keeps the whole command - #2822
Merged
Merged
Conversation
…mand An unquoted ` #` starts a YAML comment, so the run step was truncated to `echo "Labels for pull request` and failed with an unterminated quote.
Contributor
|
@milenkovicm this fixes the broken ci btw |
milenkovicm
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed. This is a one-line CI fix for a check that fails on every pull request.
Rationale for this change
The
Triggerjob indev_pr_trigger.yml(added in #2778) fails on every pull request with:The step is
run: echo "Labels for pull request #$PR_NUMBER are applied by dev_pr.yml". Because the value is a plain YAML scalar,#starts a comment, so the runner gets onlyecho "Labels for pull requestand the shell reports the unterminated quote. Labels still get applied, sincedev_pr.ymldoesn't check the trigger run's conclusion, but every PR shows a red check.What changes are included in this PR?
The
run:value is now single-quoted, so YAML keeps the whole command. I parsed the file before and after the change to confirm that the old version is cut off at#and the new one keeps the full command.Are there any user-facing changes?
No.