Repository navigation
fix(python): use a non-default codec in the shuffle compression setter test - #2829
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed. This fixes a test that fails on
main.Rationale for this change
test_typed_setterschecks that each setter's test value differs from the default, then sets it and reads it back. #2805 madezstdthe default shuffle compression codec, but the test still setszstd, sotest_typed_setters[with_shuffle_compression_codec-...]now fails withassert 'zstd' != 'zstd'. That fails the Python release test jobs.What changes are included in this PR?
The test sets
lz4instead, which is still a valid codec and no longer the default.Are there any user-facing changes?
No.