Repository navigation
minor(python): split test_context into multiple files - #2838
Open
milenkovicm wants to merge 1 commit into
Open
milenkovicm wants to merge 1 commit into
milenkovicm wants to merge 1 commit into
Conversation
Contributor
Author
|
i believe this will wrap up my work on ballista python for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. This only reorganizes tests.
Rationale for this change
python/python/tests/test_context.pyhad grown to ~1000 lines that covered queries, reads, UDFs, writes and config. That made it hard to find a test or see what an area covers. This PR splits it by topic and changes no test logic.What changes are included in this PR?
The test bodies moved unchanged. Each existing section of
test_context.pybecame its own file:conftest.pycluster,ctx(native and Python client) andndjson_filefixtures_util.pyTEST_CSV,EXPECTED_A, ...), xfail markers and helpers (to_table,read_back,write_df, ...)test_context.pycluster_configdeprecation, explain and error handlingtest_read.pycache()test_udf.pytest_write.pywrite_table,INSERT INTO,COPY TOtest_session_config.pyBallistaConfigExtensionand information_schema tests, which sit next to the other config testsUnused imports were removed with
ruff.The
clusterfixture keepsscope="module", so each file now starts its own test cluster. Locally the split files still run in ~20s.Verification
pytest --collect-onlygives the same count: 249 tests.pyteston the affected files: 229 passed, 20 xfailed. The xfails are the existing strict xfails.ruff checkandruff formatare clean.Are there any user-facing changes?
No. Only tests changed.