Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refs #7573. This draft does not close the issue.
Rationale for this change
Open a collaboration branch following @dwsmith1983's request. The initial commit supplies an independently runnable Delta reference baseline. @dwsmith1983 plans to contribute his Rust ordering code and establish a working base before handing it back for extension and cleanup.
The accepted issue scope remains Delta-compatible
InterleaveBitsfor one or two INT inputs. Hilbert ordering and broader clustering operations require separate scope; this draft does not claim support for them.What changes are included in this PR?
Based on main at
2f9552d022eb84a79b31b3870c70be9725fdb41f. The initial files do not overlap our six other open upstream PRs, including #7593; this baseline does not depend on that pairing PR.How are these changes tested?
Apollo: fresh compilation and execution on Spark 4.2.0 / Java 17, Delta 4.4.0 and 4.4.1, stock Spark and released Comet 1.2.0,
local[2], 2 GiB driver. Each lane requires 15 named checks; row/schema parity is compared between stock and Comet. An accelerated control verifies Comet is active, while the requested expression can still fall back to Spark.These are manual reference probes, not reactor tests or native acceptance. Current-main runtime, the future Rust implementation and performance remain unverified. Before readiness, add native plan assertions and CI tests, preserve fallback for unsupported types/arities, and validate the native integration against Delta's implementation and tests.