Repository navigation
Conversation
Add a public function that turns a DataFusion physical filter into an Iceberg predicate. The predicate matches every row the filter matches. It can match more rows, so callers still apply the filter. The function returns None when no part of the filter converts. It is exported as iceberg_datafusion::read::convert_physical_filter_to_predicate.
IcebergDataSource now accepts physical filters through try_pushdown_filters. It reports each one as not pushed down, so DataFusion still applies it. When the scan opens, it converts the filters with convert_physical_filter_to_predicate and ANDs them onto its predicate. The filters are available through IcebergDataSource::filters.
Perseus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
iceberg_datafusion::read::convert_physical_filter_to_predicate, which turns a DataFusion physical filter into an Iceberg predicate.IcebergDataSourceuses it for the filters DataFusion pushes into the scan.The data source:
try_pushdown_filters, and reports each as not pushed down, so DataFusion still applies itANDs the result onto its predicateIcebergDataSource::filtersThis is a first step toward #68.