Skip to content

perf(theta,tuple): add inlining hints to codec, hashing and error paths - #341

Merged
tisonkun merged 1 commit into
apache:mainfrom
davecromberge:perf-inline-hints
Nov 10, 2026
Merged

tisonkun merged 1 commit into
apache:mainfrom
davecromberge:perf-inline-hints

Conversation

@davecromberge

Copy link
Copy Markdown
Member

Adds #[inline] to the byte codec, the sketch hash function and the primitive Tuple summary codecs, and marks the insufficient-data error constructors cold, so the per-entry serde loops and the update loop inline reliably across crates.

  • Tuple serialize 3.6× and deserialize 2.4× faster; Theta and Tuple updates unchanged.
  • Prevents a ~23% update slowdown observed when the hash function grows slightly.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM.

@tisonkun
tisonkun merged commit a599256 into apache:main Nov 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants