Repository navigation
perf(theta): gather and bucket-sort hashes when compacting update sketches - #344
Open
davecromberge wants to merge 1 commit into
Open
davecromberge wants to merge 1 commit into
davecromberge wants to merge 1 commit into
Conversation
…tches Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up
ThetaSketch::compactby gathering retained hashes without a per-slot branch and bucket-sorting them for ordered output; the compact bytes are unchanged.sort_unstable; a bucket over 32 entries or fewer than 256 hashes falls back tosort_unstable.Speedup vs
mainfrom the characterizationtheta_compact_serde_profilejob (lg_k 12; geometric mean over each band, best of 3 interleaved passes):compact(true)compact(false)Ordered speedup split between the two parts (separate interleaved run including a gather-only build):
Unordered compaction gets its whole gain from the gather.
🤖 Generated with Claude Code