[server] Remove lookup lock for PaimonLakeTableLookuper - #4050
Merged
Conversation
Member
Author
|
PTAL @luoyuxia . this has been validated in the initial benchmark |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Fluss-level serialization in PaimonLakeTableLookuper to enable higher-throughput concurrent lookups by relying on Paimon’s concurrency support, while refactoring internal state to avoid shared mutable per-lookup encoders/partition helpers.
Changes:
- Removed the
synchronizedlookup/close lifecycle lock and introduced lazy-init locking only. - Reworked lookup-file tracking/metrics to be per-thread via
ThreadLocal+ try-with-resources helper. - Refactored file registration/refresh to use a concurrent per-partition-bucket registry and per-call encoders/projections.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
cc @luoyuxia |
luoyuxia
reviewed
Aug 30, 2026
Clarify the file refresh helper responsibilities through method names and make TrackingMetrics a static nested class. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 12/12 AI-Contributed/UT: 0/0
Contributor
|
I append a small commit to address the minor comments |
luoyuxia
approved these changes
Aug 30, 2026
Member
Author
Thank @luoyuxia for your review in the weekend ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon 1.3.1 serializes calls toLocalTableQuery.lookup, limiting the throughput of Fluss’sPaimonLakeTableLookuper. Paimon 2.0 supports concurrent lookups, so Fluss should avoid imposing an additional concurrency restriction at its own layer. This allows users running Paimon 2.0—or a custom-patched earlier version—to benefit from concurrent lookups and improved performance.This PR aims to fully leverage Paimon 2.0’s concurrent lookup capabilities, made possible by #4093.
Brief change log
Tests
API and Format
Documentation