[server] Stop enabling standby replicas by default for new PK tables - #4157
Merged
Conversation
AI-Contributed/Feature: 0/10 AI-Contributed/UT: 0/11 111 AI-Contributed/Feature: 0/0 AI-Contributed/UT: 0/1
swuferhong
force-pushed
the
kv-stanbdy-hotfix
branch
from
August 30, 2026 13:54
bc7e7ed to
8b5ab80
Compare
wuchong
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4156
The coordinator injected 'table.kv.standby-replica.enabled=true' into every newly created primary key table. The standby replica feature is only partially merged: the standby election has landed, but the hot-standby and standby bootstrap paths are still open, so the upcoming release would expose an incomplete feature to all new PK tables.
Drop the auto-enablement so the option stays absent unless a user sets it explicitly. TableConfig#isStandbyReplicaEnabled() already treats an absent option as disabled, and an empty standby list makes replicas follow the pre-standby follower path, so no other production code changes are needed. Standby replicas can still be enabled per table via ALTER TABLE.
Also reword the option description accordingly and drop the test assertions that expected the property to be injected at creation time.
Brief change log
Tests
API and Format
Documentation