[mattcasters]

A new Hop configuration now gets a local pipeline run configuration and a local workflow run configuration.

hop setup copies the install default-project template into the new default project. That copy only took the top level, so project-config.json arrived and metadata/ was created empty. The standard local run configurations live under metadata/ and were left behind. The copy now includes nested metadata. When the template does not already contain those configurations, setup writes them, together with the local execution info location and data profile they use. An existing default project that already has project-config.json is left unchanged.

fixes #9089

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
• Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[bamaer]

Thanks @mattcasters, good catch that SELECT_CHILDREN only copies one level. That is why metadata/ arrived empty.

Built the setup plugin from this branch and ran its unit tests (all pass). Also ran the config copy and project creation against the real install config/ folder: the new default project gets the local pipeline and workflow run configurations plus local-audit and first-last.

Blockers

None.

Should fix

• HopVfsFiles.copyTree is used twice by setup: to copy <install>/config into the new config folder, and to copy the default-project template into ~/Documents/hop/default. Copying all subfolders fixes the second one. The first one now also copies projects/default and projects/samples into the new config folder (for example ~/.local/share/hop/projects/...). hop-config.json points at neither, so they are unused copies. Suggestion: copy all subfolders only for the project template (ProjectRegistrationWriter.java:125) and keep the one-level copy in ConfigFolderSeeder.java:70.

[bamaer]

Thanks @mattcasters, that resolves it. Re-ran the setup unit tests and the copy against the real install config: the config folder now only gets hop-config.json and an empty projects/, and the default project gets the run configurations.

[mattcasters]

Thanks @bamaer! Fixed in ac04367: HopVfsFiles now has copyChildren (one level, used by ConfigFolderSeeder) and copyTree (deep, used only for the project template in ProjectRegistrationWriter). Added tests that projects/default and projects/samples aren't seeded and that nested template folders are copied.