Docs: Enhance maintenance documentation with new actions - #17939
talatuyarer wants to merge 2 commits into
Conversation
uros-b
left a comment
There was a problem hiding this comment.
Every documented action, method signature, default value, option, procedure link, and spec anchor has been traced to upstream/main and verified accurate. Several passages are verbatim the source Javadocs, formatting is clean, and build-docs is green on ubuntu and macOS.
One gap that's maybe worth a follow-up is a single sentence on removeDanglingDeleteFiles's no-op behavior for unpartitioned tables.
docs/docs/maintenance.md(removeDanglingDeleteFiles section):RemoveDanglingDeletesSparkAction.execute()short-circuits to an empty result for unpartitioned tables becauseManifestFilterManageralready cleans dangling deletes on every commit for those tables. Users who call this on an unpartitioned table will see zero files removed and may be confused; one sentence noting the no-op behavior would prevent a common support question.
But overall this is a nice change - thank you @talatuyarer! and please ping relevant committers to take this further, e.g. @aokolnychyi who owns Spark rewrite and compute-stats actions.
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for adding more docs!
I have a few minor comments for clarity and readability.
Please take a look: kevinjqliu@90d16ac
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
Adds documentation for six table actions that were missing from maintenance.md