Skip to content

Spark: Restore 4.2 commit history - #17967

Merged
szehon-ho merged 5 commits into
apache:mainfrom
manuzhang:spark42-history-replay
Sep 9, 2026
Merged

szehon-ho merged 5 commits into
apache:mainfrom
manuzhang:spark42-history-replay

Conversation

@manuzhang

@manuzhang manuzhang commented Sep 6, 2026

Copy link
Copy Markdown
Member

Summary

The cleanup from #17952 remains present because the replay starts from the current Spark 4.1 sources.

Merge Requirement

This PR must not be squash-merged because squashing would discard the commit and rename history it restores. Please use a merge commit or rebase merge.

Validation

  • ./gradlew --no-daemon :iceberg-spark:iceberg-spark-4.2_2.13:assemble :iceberg-spark:iceberg-spark-extensions-4.2_2.13:assemble :iceberg-spark:iceberg-spark-runtime-4.2_2.13:assemble
  • ./gradlew --no-daemon :iceberg-spark:iceberg-spark-4.2_2.13:test --tests org.apache.iceberg.spark.TestSparkExecutorCache --tests org.apache.iceberg.spark.actions.TestRewriteDataFilesAction
  • git diff --check upstream/main...HEAD
  • Verified spark/v4.1 is unchanged from upstream/main

AI Disclosure

  • Model: GPT-5
  • Platform/Tool: Codex
  • Human Oversight: partially reviewed
  • Prompt Summary: Revert the squashed Spark 4.2 commits and replay the original commits from PR Spark: Add support for 4.2.0 #14984 while preserving current Spark 4.2 compatibility.

@manuzhang

Copy link
Copy Markdown
Member Author

@szehon-ho @huaxingao @nssalian This is to fix the Spark 4.2 commit history and should be Rebase and merge. Here are the detailed changes. We'd better move fast to avoid further conflicts and complexity. Please take a look. Thanks!

Summary

The cleanup from #17952 remains present because the replay starts from the current Spark 4.1 sources.

@nssalian nssalian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged in so we can clean up the history and put the 4.2 baseline back. Thanks @manuzhang

@szehon-ho szehon-ho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry that was my fault!

@szehon-ho

Copy link
Copy Markdown
Member

Looks like this is going to be a bit hard.

Looks like the current conflict is caused by #17972 updating sqlite-jdbc.

Screenshot 2026-09-08 at 5 10 29 PM

What do you think @manuzhang , can you rebase again and then me or @huaxingao can try again? I think only file that would conflict outside 4.2 line is gradle/libs.version

@manuzhang
manuzhang force-pushed the spark42-history-replay branch from ceb5000 to 79ba7f3 Compare September 9, 2026 02:20
@manuzhang

Copy link
Copy Markdown
Member Author

@szehon-ho @huaxingao It should be good for Rebase and merge now.

@szehon-ho

szehon-ho commented Sep 9, 2026

Copy link
Copy Markdown
Member

ok ill try to do it tonight, thanks again! @huaxingao can also do it if the CI finish

@szehon-ho
szehon-ho merged commit 3f5539d into apache:main Sep 9, 2026
36 checks passed
@szehon-ho

Copy link
Copy Markdown
Member

"Rebase and merged", thanks @manuzhang! Let me know if anything else is wrong

@manuzhang

Copy link
Copy Markdown
Member Author

@szehon-ho Thanks for the prompt action. I excluded Spark 4.2 from source release in this PR, but that would crash our source release process. To fix it, I've opened #18024 to revert the change. Please help review. cc @huaxingao @nssalian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants