Spark: Restore 4.2 commit history - #17967
Conversation
8c4fb18 to
ceb5000
Compare
|
@szehon-ho @huaxingao @nssalian This is to fix the Spark 4.2 commit history and should be
|
nssalian
left a comment
There was a problem hiding this comment.
Let's get this merged in so we can clean up the history and put the 4.2 baseline back. Thanks @manuzhang
szehon-ho
left a comment
There was a problem hiding this comment.
Thanks, sorry that was my fault!
|
Looks like this is going to be a bit hard. Looks like the current conflict is caused by #17972 updating sqlite-jdbc.
What do you think @manuzhang , can you rebase again and then me or @huaxingao can try again? I think only file that would conflict outside 4.2 line is gradle/libs.version |
ceb5000 to
79ba7f3
Compare
|
@szehon-ho @huaxingao It should be good for |
|
ok ill try to do it tonight, thanks again! @huaxingao can also do it if the CI finish |
|
"Rebase and merged", thanks @manuzhang! Let me know if anything else is wrong |
|
@szehon-ho Thanks for the prompt action. I excluded Spark 4.2 from source release in this PR, but that would crash our source release process. To fix it, I've opened #18024 to revert the change. Please help review. cc @huaxingao @nssalian |

Summary
031135677395a3fbc90a2e33f58a9fa3983335f5) and its follow-up cleanup (e76d63584d7f83b102026749e1ae0f91813cb78e).spark/v4.1tospark/v4.2, copy it back, and add Spark 4.2 support. The support commit includes all follow-up fixes.StreamingOffsetJSON generation (Core, Hive, Spark: Auto close JsonGenerator using try-with-resources #17931).TableInfoAPI changes from Spark 4.1: Mark overrides of deprecated Spark API as deprecated #16028 out of Spark 4.2, where the requiredCatalogV2Utilsignatures are unavailable.The cleanup from #17952 remains present because the replay starts from the current Spark 4.1 sources.
Merge Requirement
This PR must not be squash-merged because squashing would discard the commit and rename history it restores. Please use a merge commit or rebase merge.
Validation
./gradlew --no-daemon :iceberg-spark:iceberg-spark-4.2_2.13:assemble :iceberg-spark:iceberg-spark-extensions-4.2_2.13:assemble :iceberg-spark:iceberg-spark-runtime-4.2_2.13:assemble./gradlew --no-daemon :iceberg-spark:iceberg-spark-4.2_2.13:test --tests org.apache.iceberg.spark.TestSparkExecutorCache --tests org.apache.iceberg.spark.actions.TestRewriteDataFilesActiongit diff --check upstream/main...HEADspark/v4.1is unchanged fromupstream/mainAI Disclosure