Fix unsolicited AirGap responses on idle timeout - #18502
Open
Caideyipi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Treat receiver read timeouts before any request byte as normal idle periods.\n- Avoid sending unsolicited AirGap FAIL (0xff) responses on idle timeout.\n- Close a connection that times out after a partial request, without replying, so the sender can reconnect and retry from a clean frame boundary.\n- Add regression tests for idle and partial-request timeouts.\n\n## Tests\n\n- mvn -pl iotdb-core/datanode -Dtest=IoTDBAirGapReceiverTest -Dsurefire.failIfNoSpecifiedTests=false -DforkCount=0 test\n- 5 tests passed.\n- Checkstyle and Spotless passed.\n\nThe PR is based on �pache/iotdb:master.