Repository navigation
Release the thread lock when IPC acquisition fails - #2203
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release the thread lock when
LockLocalStoragecannot acquire its IPC lock. A failed__enter__never reaches__exit__, so the previous code left the thread lock held after a timeout, acquisition error or interruption, preventing reuse of the same lock object.Regression coverage verifies cleanup and successful reuse after each failure, while preserving the original exceptions. This is independent of the lock-file cleanup in #2172.
Fixes #2202
Status
Ready for review.
Validation
git diff --checkpass for the changed files.Checklist