[LIVY-1085][TEST] Skip remaining R test paths when -DskipRTests is specified - #561
Merged
Merged
Conversation
…ecified Two R-dependent tests (SharedSessionSpec, InteractiveSessionSpec) ran a real sparkr interpreter even with -DskipRTests=true, unlike every other R test in the suite. Guard both with the same sys.props pattern already used by SparkRInterpreterSpec/SparkRSessionSpec/BatchIT/InteractiveIT, and make InteractiveSessionSpec's downstream execution_count expectation conditional on the flag, since it depends on the skipped R statement having incremented the session's shared statement counter. Verified via mvn test runs of both specs with -DskipRTests=true (R test cancels, rest pass) and the default -DskipRTests=false on a machine with R installed. Generated-by: Claude Code (claude-sonnet-5)
Contributor
|
It looks like there might still be an issue here. Could you double check this? When testing locally with the R binary renamed to |
Contributor
Author
|
@roczei Thanks for reviewing the PR and testing it locally! To clarify the test behavior: the R tests are only skipped when |
Contributor
|
Sorry, I have no idea why I was testing it with false. It works completely fine in this case |
roczei
approved these changes
Sep 23, 2026
Contributor
Author
|
Thank you @roczei! Appreciate you checking out the PR and testing it on your machine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Two R-dependent tests (
SharedSessionSpec,InteractiveSessionSpec) ran areal
sparkrinterpreter even with-DskipRTests=true, unlike every otherR test in the suite. Guard both with the same
sys.propspattern alreadyused by
SparkRInterpreterSpec/SparkRSessionSpec/BatchIT/InteractiveIT,and make
InteractiveSessionSpec's downstreamexecution_countexpectationconditional on the flag, since it depends on the skipped R statement
having incremented the session's shared statement counter.
How was this patch tested?
Verified via
mvn testruns of both specs with-DskipRTests=true(R test cancels,rest pass) and the default
-DskipRTests=falseon a machine with R installed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-sonnet-5)