Repository navigation
docs(sandbox-lint): declare Grok harness support - #1598
Open
KatalKavya96 wants to merge 1 commit into
Open
KatalKavya96 wants to merge 1 commit into
KatalKavya96 wants to merge 1 commit into
Conversation
Contributor
Author
|
@potiuk This should be the final cleanup slice for #1416.
|
Kaap10
approved these changes
Oct 12, 2026
Kaap10
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Thank you @KatalKavya96 for wrapping up the Grok harness documentation and metadata alignment for #1416.
- Declaring Grok under
--any-harnessaccurately reflects that Grok relies on the shared OS-level posture enforcement components (agent-iso.shandagent-guard) rather than a dedicated sandbox profile. - Updating
tools/sandbox-lint/src/sandbox_lint/posture.pyalso nicely cleans up the stale reference to Gemini CLI. - Verified locally: all posture tests,
mypy, andruffchecks pass cleanly, and all 11 CI checks are green.
One minor non-blocking editorial nit: in tools/sandbox-lint/README.md (line 26), Grok was appended at the end (..., OpenCode, Kiro, Grok), whereas the generated vendor-neutrality table sorts it alphabetically (..., Gemini CLI, Grok, Kiro, OpenCode). Feel free to adjust if you touch the file again.
Kaap10
reviewed
Oct 12, 2026
| **Capability:** substrate:sandbox | ||
|
|
||
| **Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro | ||
| **Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro, Grok |
Contributor
There was a problem hiding this comment.
Suggested change
| **Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro, Grok | |
| **Harness:** Claude Code, Codex, Cursor, Gemini CLI, Grok, Kiro, OpenCode |
(Nit, non-blocking): Kept in alphabetical order to match the generated table in docs/vendor-neutrality.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/sandbox-lintthrough the existing harness-neutral--any-harnessposture check.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
uv run --project tools/sandbox-lint --group dev pytest tools/sandbox-lint/tests/test_posture.py--any-harnesscoverage verifies complete, incomplete, missing, and auto-detected framework posture casesRFC-AI-0004 compliance
--any-harnessposture checkLinked issues
Refs #1416
Notes for reviewers (optional)
This PR does not add a Grok-specific sandbox parser or new security logic.
sandbox-lintalready supports runtimes without a dedicated config profile through--any-harness, which verifies the presence of the shared harness-neutral enforcement components:tools/agent-isolation/agent-iso.shtools/agent-guard/dispatch coreGrok already relies on that same external OS-level posture, so this change makes the existing support explicit in the harness declaration, documentation, CLI/help wording, and generated vendor-neutrality metadata.
No Grok-specific regression test was added because the generic
--any-harnessbehavior is already covered directly by the existing posture test suite.