Skip to content

fix(pr-management-stats): keep the parity tests from publishing a gist #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MakerFlyFly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pr-management-stats): keep the parity tests from publishing a gist #1603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tools/pr-management/tests/stats/test_json_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@

import json

import pytest

from pr_management.stats import dashboard, reference

from .helpers import comment, make_pr
Expand Down Expand Up @@ -78,6 +80,17 @@ def fake_paginated_search(query, search_q, *args, status=None, **kwargs):
monkeypatch.setattr(module, "paginated_search", fake_paginated_search)
monkeypatch.setattr(module, "fetch_codeowners", lambda repo: "")
monkeypatch.setattr(module, "fetch_ready_pr_files", lambda repo, nums: {})
if module is dashboard:
# dashboard.main() ends by publishing to a secret gist through `gh`.
# A unit test must never reach GitHub, so fail loudly if it gets there.
def refuse_publish(*args, **kwargs):
pytest.fail("unit test reached the dashboard gist publish step")

# Guard each entry point independently of main()'s current call order.
monkeypatch.setattr(module, "gist_scope_available", refuse_publish)
monkeypatch.setattr(module, "publish_gist", refuse_publish)
monkeypatch.setattr(module, "read_stats_gist_id", refuse_publish)
monkeypatch.setattr(module, "store_stats_gist_id", refuse_publish)


def _run(monkeypatch, module, out_path):
Expand All @@ -93,6 +106,8 @@ def _run(monkeypatch, module, out_path):
"--out",
str(out_path),
]
if module is dashboard:
argv.append("--no-publish") # reference.py has no publish step and no such flag
monkeypatch.setattr(module.sys, "argv", argv)
module.main()
return json.loads(out_path.with_suffix(".json").read_text())
Expand Down