Repository navigation
fix(setup): treat method:local as adopted without drift in drift-check - #1614
Merged
Merged
Conversation
The session-start drift check only knew the marketplace and snapshot methods, so the framework checkout's own self-adoption lock (`method: local`) fell through to "Malformed .apache-magpie.lock (unknown or missing method)" on every session, pointing at an upgrade that cannot fix it. A local adoption links the in-tree skills/ source, so there is no snapshot or floor to drift; report it as adopted with no drift, matching setup-preflight's LOCAL_METHOD handling. Generated-by: Claude Code (Opus 5.5)
potiuk
added
family:setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/magpie-setup/hooks/drift-check.ts, from feat(setup): add zero-token setup drift check Claude Code mod (part of #1497) #1552) only recognised themarketplaceand snapshot (git-tag/git-branch/svn-zip) lock methods.The framework checkout's own self-adoption lock (
method: local) fell through to "Malformed.apache-magpie.lock(unknown or missing method). Run/magpie-setup upgradeto repair." on every session — a false alarm pointing at an upgrade that cannot fix it.localadoption links the in-treeskills/source, so there is no snapshot or floor that can drift.The mod now reports it as adopted with no drift, matching
setup-preflight's existingLOCAL_METHODhandling (tools/setup-preflight/src/setup_preflight/core.py).Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)magpie-setupdrift-check hook)Test plan
claude plugin test plugins/magpie-setup— 10/10 pass, including the newreturns false drift for local self-adoption methodregression testclaude plugin validate --strict plugins/magpie-setuppassesprek run --all-filespasses apart from one local-only failure (a stale, untrackedstack-review/tests/directory holding just__pycache__, which the unittest hook finds empty; not in git, so CI does not see it)method: localcorrectly from the real lock, including its comments and nestedreconciled:blockRFC-AI-0004 compliance
No principles touched — read-only check, no new mutation, host access, or LLM hop.
Linked issues
Refs #1497, #1552
Generated-by: Claude Code (Opus 5.5)
🤖 Generated with Claude Code