Repository navigation
Correct plugin sources in marketplace.json - #1622
Merged
Merged
Conversation
According to Clause documentation, there is no `local` source type. Instead, we should use the path directly. When using this structure with GitHub Copilot, it works.
potiuk
approved these changes
Oct 13, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM. The {"source": "local", "path": …} object is the Codex catalog shape. The root catalog that Copilot reads takes a relative path string, which is also what check-family-plugins.py --fix already writes into .claude-plugin/marketplace.json. Leaving .agents/plugins/marketplace.json on the object form is also correct, since that is the file Codex reads.
Smaller observations
tools/dev/check-family-plugins.pyshould check that each catalog uses the right format for its client, not just that the plugin names match.check_client_catalogs()only compares names today, which is how the Codex shape got into the Copilot catalog unnoticed. A check that every entry in the rootmarketplace.jsonhas a"./plugins/<name>"stringsourcewould catch the next copy inprekrather than on someone's install. A follow-up PR is fine.docs/setup/marketplace.md:734still says the rootmarketplace.jsonis "Not yet live-installed". Your test plan is the first live install, so that row can be updated too.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to Clause documentation1, there is no
localsource type. Instead, we should use the path directly.When using this structure with GitHub Copilot, it works.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
Before the change:
After the change:
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)Linked issues
Fixes #1621
Notes for reviewers (optional)
Please read the related documentation. By using docs from another source than where the fix is tested, vendor neutrality should be ensured.