Backport security audit fixes to 3.x (f004-f008, f010, f012) - #701
Draft
gnodet wants to merge 1 commit into
Draft
Conversation
Backport of directly portable security findings from the Maven 4 API master branch to the 3.x maintenance line: - f004 (MEDIUM): deployAtEnd state machine — mark DEPLOYED after batch to prevent re-deploy on reactor re-entry - f005 (MEDIUM): deployAtEnd synchronization — DEPLOY_AT_END_LOCK monitor prevents double-fire under -T - f006 (MEDIUM): deployAtEnd javadoc — replace false atomicity claim with accurate non-atomicity description - f007 (LOW): fail-closed skip — unrecognised skip values now fail instead of silently deploying; version-aware reordering - f008 (LOW): snapshot fallback — warn when release project has only altSnapshotDeploymentRepository configured - f010 (LOW): URL redaction — mask userinfo in log messages - f012 (LOW): parse hardening — reject empty id/url in alt-repo syntax Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the directly portable security audit findings from the Maven 4 API master branch to the 3.x maintenance line (Maven 3 API):
DEPLOYEDafter batch to prevent re-deploy on reactor re-entryDEPLOY_AT_END_LOCKmonitor prevents double-fire under-Tskipvalues now fail instead of silently deploying; version-aware reorderingaltSnapshotDeploymentRepositoryconfiguredFindings NOT backported
Session,ProducedArtifact,Path)!deployAtEndbranch doesn't log on 3.x — nothing to invertAPI adaptation notes
ArtifactUtils.isSnapshot()instead of Maven 4'ssession.isVersionSnapshot()MojoExecutionExceptioninstead ofMojoExceptionFileinstead ofPathSkipModeenum andparseSkipMode()placed inDeployMojo(reused byDeployFileMojo)redactUrlUserInfo()placed inDeployMojoTest plan
deployfile-release-skipIT updated for version-aware skip reorderingdeployfile-snapshot-skipIT updated for version-aware skip reorderingCompanion to master PRs: #698, #699, #700
🤖 Generated with Claude Code