[MPH-210] Fix help:evaluate for Maven 3 model collections - #425
Merged
Conversation
Exercise help:evaluate with project.build.resources under Maven 3 so ModelMerger.MergingList serialization is covered.
Register a collection converter for model list implementations so XStream serializes them as collections instead of reflecting into JDK internals. Fixes apache#327
wilx
marked this pull request as ready for review
August 22, 2026 15:10
elharo
approved these changes
Aug 25, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #327.
help:evaluatecan receive model collections implemented by Maven 3's internalModelMerger.MergingList. XStream does not recognize that implementation as acollection and falls back to reflective serialization. On recent JDKs, this
fails when it tries to access
AbstractList.modCount.This change registers a collection converter that accepts every
Collectionimplementation and aliases the concrete runtime list class so the existing XML
root name is preserved. The evaluated list is serialized directly without
copying it.
This PR targets
master, the current 3.5.x line. The plugin still declaresMaven 3.6.3 as its runtime prerequisite. The regression IT is limited to Maven
3 because Maven 4 exposes different model collection implementations.
This replaces #416, which targeted the 3.4.x maintenance branch currently under
retirement review. PR #417 covers Maven 4-specific collection and map
implementations and can build on this Maven 3 change. The commits remain
intentionally split: the first adds the regression IT and the second applies
the fix.
Validation
mvn -Prun-its clean verify- 30 unit tests and all36 integration tests passed.
mvn -Prun-its clean verify- 30 unit tests andall 36 integration tests passed.
Invoker run passed 32 tests, skipped 2 Maven-version-specific tests, and hit
the two existing unrelated failures also documented by Fix #327: evaluate model collections on Maven 4 #417:
describe-cmd-with-goal-reportanddescribe-plugin-without-name.mvn spotless:applymade no changes.3.9.16, and JDK 21.
Checklist
[MPH-XXX]convention.mvn clean verifypassed.Apache License Version 2.0, January 2004.
been filed.