fix(ci): publish dotnet packages only from final release tags - #8311
Merged
Merged
Conversation
Xuanwo
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8310.
Rationale for this change
The "Determine version suffix" step in
release_dotnet.ymlrecognises final and rc release tags only when the run is apushevent.The release automation now pushes final tags with
GITHUB_TOKENand dispatches the workflow on the tag, so the run arrives asworkflow_dispatch, falls through to the manualrelease_typebranch, and packspreview.<run_number>.For v0.59.2 this published
Apache.OpenDAL 0.2.2-preview.78instead of0.2.2, and every later automated release would do the same.The
release_typeinput that producedpreviewandrcpackages predates the automation and is the only path in the repository that pushes an unvoted build to a public registry, so this PR removes it together with the fix.What changes are included in this PR?
release_dotnet.yml: the ref alone decides the suffix. An-rc.Ntag packsrc.N, a final tag packs the version fromOpenDAL.csprojwith no suffix, and any other ref packspreview.<run_number>. Thepublishjob runs only for final tags; every other build stays a workflow artifact.release_dotnet.yml: remove therelease_typedispatch input and the manual prerelease publishing path.scripts/release_lifecycle.py,weekly_release.yml,website/community/release/weekly.md: stop passingrelease_type=nonewhen dispatching the .NET workflow.Verified by running the suffix step's script locally for
push,workflow_dispatch, andpull_requestagainst final tags, rc tags,main, and a merge ref; only non-tag refs producepreview.N.scripts/test_release_lifecycle.pypasses excepttest_real_git_signed_final_refs, which fails on Windows before this change because it hard-codes/tmp.Are there any user-facing changes?
No change for package consumers. Release managers can no longer publish a
previeworrcNuGet package by manual dispatch; a dispatch on a non-tag ref only produces a workflow artifact. Older rc tags still declare the input withdefault: none, so dispatching them without the argument keeps working.Breaking changes
AI Usage Statement
claude-fable-5-1)defaultwhen a dispatch omits it, so old tags whose workflow still declaresrelease_typeaccept the argument-less dispatch.actionlintis not installed locally, so the workflows rely on the CI lint.