Skip to content

refactor(services/webdav): deprecate enable_conditional_read - #8314

Open
YuangGao wants to merge 2 commits into
mainfrom
webdav-deprecate-enable-conditional-read
Open

YuangGao wants to merge 2 commits into
mainfrom
webdav-deprecate-enable-conditional-read

Conversation

@YuangGao

@YuangGao YuangGao commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Refs #6708.

Rationale for this change

enable_conditional_read only masks capabilities; the request path never reads it. RFC-6707 moves endpoint-specific capability selection to CapabilityOverrideLayer, which #7562 already applied to disable_copy and enable_user_metadata.

What changes are included in this PR?

  • Deprecate enable_conditional_read as a no-op shim.
  • Declare the four read_with_if_* capabilities unconditionally.
  • Migrate the four nginx CI setups to OPENDAL_TEST_CAPABILITY_OVERRIDES.

Verified on nginx-dav and Nextcloud: 127 behavior tests pass on both.

Are there any user-facing changes?

enable_conditional_read no longer affects capabilities. Use CapabilityOverrideLayer to disable the four read_with_if_* capabilities for endpoints without ETag support.

Breaking changes

AI Usage Statement

AI-assisted implementation.

@github-actions github-actions Bot added breaking-changes releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" services/webdav size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" services/webdav size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant