Conversation
Author
|
On Apple's platforms, std file sync will use full fsync instead of regular fsync, with higher overheads. Matching the behavior on other platforms would require adding a dependency such as Some Unix platforms don't support I also ran into another issue. fsync errors should generally not be retried, but |
Huliiiiii
force-pushed
the
crash-safe-unix
branch
from
September 16, 2026 06:27
ff8a58b to
df101e2
Compare
Member
|
Could you run a benchmark to measure the differences? |
Huliiiiii
force-pushed
the
crash-safe-unix
branch
from
September 16, 2026 08:05
df101e2 to
90abad3
Compare
Author
|
Performance impact
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Write is not crash-safe on unix.
What changes are included in this PR?
fsync.Are there any user-facing changes?
N/A
Breaking changes
N/A
AI Usage Statement
GPT: Investigation, research, and exploration
Guided code implementation.