Conversation
trxcllnt
force-pushed
the
fea/buffer-cursor
branch
from
September 17, 2026 18:22
0933fc7 to
688755c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Doesn't close #8253, but possibly contributes to it.
Rationale for this change
It is sometimes necessary to interface with APIs that require seekable reads, such as archive or compression libraries.
If a Buffer represents some (contiguous or non-contiguous) data that must be deflated, a user must first materialize the bytes into a contiguous buffer and create a
std::io::Cursorin order to call deflate:This PR implements a
BufferCursor, which allows reading with forwards/backwards seekability. This allows users to call such APIs while maintaining zero-copy semantics:Bytes does not support seekable reads, otherwise I would have preferred to rely on that instead.
What changes are included in this PR?
Add a new
BufferCursorstruct that implementsstd::io::Read,std::io::BufRead, andstd::io::Seek.Are there any user-facing changes?
Yes, the new
BufferCursorstruct.Breaking changes
None
AI Usage Statement
None