Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
GeoArrow schema inference puts multiple geometry columns in the wrong positions. For example,
[first, second, id]becomes[second, first, id], and[first, id, second]becomes[first, second, id].Record each geometry field's actual DataFrame position using
enumerate. The old counter advanced only for non-geometry fields. Add two pure schema regression cases covering adjacent and separated geometry columns, including the retained scalar and geometry field types. Update the existing Arrow integration test to expect the input order and use distinct geometry-column values, verifying their association with each row name.How was this patch tested?
20efe7d4c4fwith the incorrect column order.b4967e7db037aa01bcee06a940c7c433c7deb3d9): reproduced the original stale expected-order assertion on Spark 3.5.8/Shapely 1.8.5, then all 6 focused tests passed (four Arrow input integration cases and two schema-position cases). The integration test now checks both column order and distinct geometry values for each row name. Verified runtime class origins and unchanged compact SQL serialization. Local Python was 3.11.13; the failing CI lane used Spark 3.5.0/Python 3.8. Fresh current-head CI remains pending.Did this PR include necessary documentation updates?
No public API changes; no documentation update is needed.