Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Follow-up to #3525. Shared geometry-result tests currently cast DataFrame values directly to JTS. Route these test assertions through the existing version-selected spatial boundary, so they can also read Spark's native external geometry values when that integration is added.
Add a small
SpatialTestValuestest helper and explicittoGeometrySeqaccessor. Update the shared brute-force distance helpers and the threeST_StartPointresult callers. Existing runtime profiles retain the original JTS objects, values and test settings. The incremental change after #3525 touches five test files; the native-disabled fixture configuration and generic result accessors remain unchanged. This draft targets master and currently includes #3525’s prerequisite commits; merge #3525 first to leave only the test-preparation diff.How was this patch tested?
Clean Maven
verifypassed on Spark 4.1.1 / Scala 2.13 and Spark 3.5.8 / Scala 2.12. Each run passed all 343 selected checks:SpatialTestValuesTest: 4, covering identity/nulls, SRID/factory and named/indexed access, ZM/empty values, and rejection of non-geometry inputs.functionTestScala: 244.predicateJoinTestScala: 29.BroadcastIndexJoinSuite: 66.Both runs passed Spotless and Scalastyle. Repository pre-commit and automatic commit hooks passed.
Did this PR include necessary documentation updates?
No public API changes; no documentation update is needed.