Repository navigation
Move the conversation renderer to Horizon 1401336 - #69
Merged
Merged
Conversation
Horizon's renderer now reads every shape asz lands for a record cut short or removed (apache/skywalking-horizon-ui#198). A change record whose file list a budget cut short says how many files changed, where it said none did. A removed execution record shows its time and outcome, where it said they were not reported. A provider body whose manifest has no segment list is read as having none, where the Prompt tab dropped it. The embedded copy moves to that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizon's conversation renderer now reads every shape asz lands for a record cut short or removed (apache/skywalking-horizon-ui#198). This moves the embedded copy to its merge commit,
1401336.What the page draws differently:
make conversation-view-checkconfirms the embedded file matches that commit. The page tests andmake testpass.