SOLR-16458: Migrate node properties API to JAX-RS - #4775
Open
iprithv wants to merge 1 commit into
Open
Conversation
epugh
reviewed
Aug 20, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
one qeustion about how we get a single property format.. I think we are getting away in the v2 api from a name=myproperty parameter and using a path to be more restful? Also, do we need a Ref Guide update? That often get's missed.
| tags = {"node"}) | ||
| NodePropertiesResponse getNodeProperties( | ||
| @Parameter(description = "Optional name of a single system property to return.") | ||
| @QueryParam("name") |
Contributor
There was a problem hiding this comment.
Should this be a query param or a path? /node/properties makes sense for listing. Should it be /node/properties/my.special.property ? Versus /node/properties?name=my.special.property? To be restful>
|
|
||
| @Schema(description = "JRE system properties for the Solr node. Secret values are redacted.") | ||
| @JsonProperty(SYSTEM_PROPERTIES) | ||
| public Map<String, String> systemProperties; |
Contributor
There was a problem hiding this comment.
is it really as simple as a string/string? Great.
| import org.apache.solr.security.AuthorizationContext; | ||
|
|
||
| /** | ||
| * v1 implementation of {@code GET /admin/info/properties}. Business logic lives in {@link |
| path, method, new ModifiableSolrParams(), v2RequestBody, mockCoresHandler); | ||
| } | ||
|
|
||
| private SolrParams captureConvertedPropertiesV1Params( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
GET /api/node/propertiesfrom the homegrown@EndPointwrapper to JAX-RS, matching the existing node health / logging / system APIs.NodePropertiesResponseinsolr/apiGetNodePropertiesowns redaction / collection logic/admin/info/propertiesdelegates to that class; response keysystem.propertiesis unchangedNodeApi.GetNodePropertiesSolrJettyTestRulefor named lookup, full list, and hidden-property redactionhttps://issues.apache.org/jira/browse/SOLR-16458