SOLR-18303: Stop backup cleanup from hiding the original failure - #4776
Open
iprithv wants to merge 1 commit into
Open
SOLR-18303: Stop backup cleanup from hiding the original failure#4776iprithv wants to merge 1 commit into
iprithv wants to merge 1 commit into
Conversation
Signed-off-by: prithvi <prithvisivasankar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incremental collection backup fails during shard copy,
BackupCmdlogs the realSolrExceptionand then tries to clean up the partial backup. Cleanup deleteszk_backup_<id>, which is only created after shard copy.If shard copy fails first, that directory does not exist.
LocalFileSystemRepository.deleteDirectory()goes through NIO/PathUtilsand throwsjava.nio.file.NoSuchFileException. Cleanup only caughtjava.io.FileNotFoundException, which is a different type, so the not-found exception replaced the original backup error in the API response.Operators then see a bare missing-path error instead of the actual cause (allow-paths, no leader, shard copy failure, etc.).