Conversation
uros-b
reviewed
Sep 28, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @nchammas
let's wait for @cloud-fan too
cloud-fan
approved these changes
Sep 29, 2026
Contributor
|
@HyukjinKwon can you also take a look? |
HyukjinKwon
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of pushing to spark-website twice during a release, push only once.
Why are the changes needed?
apache/spark-website#699 automates the generation of HTML for the website. There could be a race between the release script's two pushes and spark-website's CI push that causes the release script to fail. It wouldn't be a disaster, just annoying. Better to avoid it by pushing to spark-website only once from the release script.
Even if apache/spark-website#699 is not merged, this change is still valid (though the comment becomes stale). So it's better to merge this before the spark-website PR is merged.
In the future, I think it would be better if we moved the portion of the release script related to the website into the spark-website repo and just called it from here. It's not great that we currently have to open PRs against two separate repos for a change that should in theory be limited to the website repo.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I'm not sure how to test this holistically. Will think about that.
Was this patch authored or co-authored using generative AI tooling?
No.