Remove DRPC per-function request queues once they are empty - #8985
Open
rzo1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map of function name to request queue in
DRPCgained an entry for each function name a client asked about, and no code path ever removed one:cleanup()removed the request from a queue andcleanupAll()drained queues, but the queue object and its map entry stayed for the life of the process.Entries are now dropped once nothing is waiting in them, using
compute/computeIfPresentso the map stays race-free. A registered function is served exactly as before, its queue simply being recreated by the nextexecute(). ExtendsDRPCTest.