Verify the peer identity of the Netty TLS server the worker client connects to - #8987
Open
rzo1 wants to merge 1 commit into
Open
Verify the peer identity of the Netty TLS server the worker client connects to#8987rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StormClientPipelineFactorycalledsslContext.newHandler(ch.alloc()), the overload that supplies no peer host or port, so the client engine had no address to check the server certificate against.The peer host and port are now passed through from the
Client, and a newstorm.messaging.netty.tls.hostnameVerificationkey (default true) can turn the check off.This requires certificates carrying a SAN that matches the address workers connect to, host or IP SANs rather than DNS only. Only affects clusters with
storm.messaging.netty.tls.enableset; TLS is off by default. AddsStormClientPipelineFactoryTest.