Pass only the required Kafka consumer properties to the spout lag monitor - #8988
Open
rzo1 wants to merge 1 commit into
Open
Pass only the required Kafka consumer properties to the spout lag monitor#8988rzo1 wants to merge 1 commit into
rzo1 wants to merge 1 commit into
Conversation
jnioche
approved these changes
Aug 21, 2026
reiabreu
approved these changes
Aug 22, 2026
reiabreu
left a comment
Contributor
There was a problem hiding this comment.
Disclaimer: this comment was generated with the help of an LLM.
Approving — the allowlist approach is sound (forwarding only connection-relevant consumer properties is safe by construction). One compatibility note worth calling out in the release notes: because topology-supplied config.* properties are now filtered, any lag-monitor setup that relied on a topology-provided sasl.jaas.config (or another now-dropped property) to authenticate to the brokers will stop reporting lag after upgrade, until the monitor is given its own credentials on the UI host. It's the correct behavior, just a silent change for those setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopologySpoutLagcopied everyconfig.-prefixed key out of the submitted spoutjson_confinto the properties file handed to thestorm-kafka-monitorprocess.Only the properties the monitor actually reads are now forwarded, and anything dropped is logged by name so a lag display that stops working can be diagnosed.
topics,groupid,bootstrap.serversandsecurity.protocolare unaffected, since they travel via argv. Lag monitoring remains off by default. AddsTopologySpoutLagTest.