Skip to content

slice_stale_generation.test.py: Accept either abort shape #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bneradt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

slice_stale_generation.test.py: Accept either abort shape #13596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/gold_tests/pluginTest/slice/slice_stale_generation.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,12 +293,15 @@ def _verify_aborted_response(self) -> None:
client = self._replay_phase(tr, 'mixed')
# Let the reference block go stale so that only it is revalidated.
tr.Processes.Default.Command = f'sleep {self._expiry_wait}; ' + tr.Processes.Default.Command
# Slice aborts the transaction, so the client never reads a response at
# all: not a short body, no response header. verifier-client exits 1.
# Slice aborts the transaction, so the client never reads a complete
# response. How far slice got before aborting decides what the client
# sees: either a response header it cannot parse, or a complete header
# whose body never arrives. Both are the same failure, and which one
# shows up is timing, so accept either. verifier-client exits 1 for both.
client.ReturnCode = 1
client.Streams.stdout += Testers.ContainsExpression(
'Failed to find a well-formed, completed HTTP response: PARSE_INCOMPLETE',
'The client should not receive a parsable response.')
'Failed to find a well-formed, completed HTTP response: PARSE_INCOMPLETE'
'|Content-Length body underrun for key mixed', 'The client should not receive a complete response.')
client.Streams.stdout += Testers.ContainsExpression(
'Failed HTTP/1 transaction with key: mixed', 'The transaction should fail.')
self._still_running(tr)
Expand Down