Repository navigation
fix(deps): take fumadocs-openapi 12.6.5, which keeps long paths and strings in their boxes #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8cba3e4
build(deps): fumadocs-openapi 12.6.5 with one copy of lucide-react
bc3a32e
docs(portal): say that Fumadocs writes a credential in the cURL sampl…
b3ef74b
build(deps): count both engine warnings that json-magic 0.19 adds on …
b105d56
fix(portal): hand a sign-in's answer to the playground through the ta…
d4e385c
docs(portal): say that tags loading beside a waiting sign-in answer i…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI tests
@scalar/json-magic0.16.1, while customers get 0.19.1.Because of this override, every CI job runs json-magic 0.16.1. An
npm install -gof the CLI ignores pnpm overrides and gets 0.19.1. That code runs in two places:create-page.jsanddereference.jscallcreateMagicProxyoperation.jsandusage-tabs.jsimportgetRawI checked that 0.19 is safe on the path we use. fumadocs-openapi imports only
createMagicProxyandgetRawfrom@scalar/json-magic/magic-proxy, and both exist in 0.16 and 0.19. In 0.19.1 themagic-proxycode doesn't loadundici; onlybundle/plugins/fetch-urlsdoes. So the extra EBADENGINE warnings on Node 22.14 don't affect this path at runtime.The gap is that nothing automated checks 0.19 before this merges.
portal_tests.ymlinstalls the packed CLI the way npm does, but it only runs on push todev. It also has aworkflow_dispatchtrigger, so could you:portal_tests.ymlon this branch (gh workflow run portal_tests.yml --ref chore/fumadocs-openapi-12-6-5) and link the run here before merging? Then the manual 0.19 checks in the description are backed by CI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, an apology: you had already started a run on this branch (44030994779), and my dispatch cancelled it 32 minutes in, because the workflow cancels a run in progress on the same ref. I should have listed the runs first. I restarted one, and it has finished.
The run: https://github.com/apimatic/apimatic-cli/actions/runs/44035040377, on b105d56. The one commit after it changes a comment only.
What it backs. With the packed CLI installed as npm does, so with json-magic 0.19.1, these pass:
generate the portal,visual,visual — nav.json,generate the auth portalandgenerate the petstore portal. So CI now covers 0.19 for building a portal and for the visual baselines.It is not green, and neither is
dev. Your baseline run ondev(44031027356, at 8e394e5) fails the same way. The same 16 tests fail in both runs, with the same messages:artifacts: the petstorellms.txtbaseline lacks thelistPetVisitsline.functional: every auth playground test times out onlocator('#nd-page').locator('form').first(). That is the inline playground form, which the suite'smainstill drives; 12.6 moved the playground into a dialog. Each test waits out its two minutes, so the job runs into its 45-minute limit.The branch run got two tests further than
devbefore that limit, the digest test and the petstore servers test, and both stop on the same missing form.So neither failure comes from this PR, but the playground tests cannot vouch for 0.19, or for anything else in the playground, until the suite is updated. apimatic/v4-test-automation#26 is that update for 12.6; it is open and conflicts with
main, and the new field rows of 12.6.3 will likely need the page object changed again.The issue: apimatic/apimatic-io#2353, with the condition (the Node floor reaching 22.19, in
engines.nodeand in the test matrix) and the steps to take the pin out.I checked your reading of the code paths and agree. To be exact about the files:
createMagicProxyis inutils/document/dereference.js, andgetRawinoperation.js,ui/operation/usage-tabs.js,utils/create-page.js,utils/get-example-requests.jsandutils/schema.js. In 0.19.1 nothing the magic proxy imports reaches undici; onlybundle/plugins/fetch-urls/fetch-public-url.jsloads it.