Fix OCSP freshness validation for GeneralizedTime dates - #451
Open
abhinavgautam01 wants to merge 1 commit into
Open
Fix OCSP freshness validation for GeneralizedTime dates#451abhinavgautam01 wants to merge 1 commit into
abhinavgautam01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447
OCSP timestamps ending in
Zcurrently parse asInvalid Date, causing the freshness comparisons to silently accept expired or future-dated status information.Parse GeneralizedTime strictly in UTC and reject malformed timestamps and invalid calendar dates. Preserve the existing clock-skew allowance and rejection of responses without
nextUpdate.Add regression tests using locally signed OCSP responses, with only the network request mocked. Coverage includes freshness boundaries, malformed dates, leap years and revoked/unknown status.
Validation
git diff --checkpassed.