fix: abort timed-out OCSP requests - #456
Open
TorinAsakura wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455.
Abort OCSP requests when the 30-second deadline expires, including requests that have received headers but are still waiting for the body. Previously, a body timeout could leave the socket open and return a non-retryable verification failure.
Use one
AbortControllerand timer for the request and body read. Clear the timer and abort the request infinally, including HTTP error responses. A deadline abort returnsRETRYABLE_VERIFICATION_FAILURE. Other body-read and OCSP validation errors keep their existing classification.Two regression scenarios use a local HTTP server: one response never sends headers; the other sends a partial body and stops. Both verify that the SDK returns a retryable failure and closes the connection when the deadline expires.
Validation:
yarn buildjws_verification.test.ts; the existing live OCSP test was excludedgit diff --check