Repository navigation
Exclude application data directory from backups - #1660
Closed
somiljain2006 wants to merge 19 commits into
Closed
somiljain2006 wants to merge 19 commits into
somiljain2006 wants to merge 19 commits into
Conversation
Author
|
@jglogan @katiewasnothere @realrajaryan Can you review this pr? |
somiljain2006
force-pushed
the
Container-Backup-Exclusion-fix
branch
from
June 15, 2026 22:46
c6b50c0 to
27af44b
Compare
Author
|
@dkovba CI failure appears unrelated to this change. |
dkovba
reviewed
Jun 15, 2026
Author
|
@dkovba, I have addressed the changes. Can you review them |
dkovba
reviewed
Jun 16, 2026
dkovba
reviewed
Jun 17, 2026
dkovba
left a comment
dkovba
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution 👍
dkovba
approved these changes
Jun 17, 2026
dkovba
reviewed
Jun 17, 2026
dkovba
approved these changes
Jun 17, 2026
Author
|
@dkovba Can this be merged? |
dkovba
requested changes
Aug 28, 2026
dkovba
left a comment
dkovba
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay. Please consider additional feedback.
dkovba
reviewed
Aug 29, 2026
Code Coverage
|
dkovba
requested changes
Sep 2, 2026
dkovba
requested changes
Sep 2, 2026
dkovba
left a comment
dkovba
left a comment
Contributor
There was a problem hiding this comment.
Users should be able to change which folders are excluded from backup, so we shouldn't overwrite that choice on every start. Set the exclusion only when a folder is first created.
dkovba
requested changes
Sep 8, 2026
|
|
||
| do { | ||
| let appRootURL = URL(fileURLWithPath: appRoot.string) | ||
| try FileManager.default.createDirectory(at: appRootURL, withIntermediateDirectories: true) |
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import Foundation | ||
| import Logging |
Contributor
There was a problem hiding this comment.
Are we supposed to have a test here?
|
|
||
| try FileManager.default.createDirectory(at: containerRoot, withIntermediateDirectories: true) | ||
|
|
||
| do { |
Contributor
There was a problem hiding this comment.
It seems this hasn't been addressed: #1660 (review)
Contributor
|
Closed in favor of #2412. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
[Why is this change needed?]
Fixes #1554
The application data directory (~/Library/Application Support/com.apple.container) can contain large, sparse files whose apparent size is significantly larger than their allocated size. This may cause backup tools to process unnecessary data or fail when backing up the container application data.
This change marks the application root directory with URLResourceKey.isExcludedFromBackupKey, preventing it from being included in backups while preserving normal container functionality.
Testing
Automated Testing:
Manual Verification: