Repository navigation
Exclude recreatable container data from Time Machine - #2412
Open
abdullahtas0 wants to merge 1 commit into
Open
abdullahtas0 wants to merge 1 commit into
abdullahtas0 wants to merge 1 commit into
Conversation
Sparse image snapshots and container root filesystems make backups stall and can trigger thinning. Volume data stays included.
Fxxx |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
All commits must be signed and verified. Pull requests containing unsigned or unverified commits cannot be built or merged. See the GitHub documentation for instructions.
For all but trivial fixes, make sure to first create a GitHub issue that concisely describes the bug or desired enhancement as justification for the change. Large PRs with no justifying issue will be closed.
Type of Change
Motivation and Context
Fixes #2406.
Image snapshots and container root filesystems are large sparse files. Time Machine backs them up slowly, and that can trigger thinning of older backups. Both can be recreated by pulling the image or creating the container again.
snapshots/andcontainers/now receive the sticky backup exclusion when those directories are created, and again on later service starts so an existing install is covered the next time the system starts. Named volume data undervolumes/stays included.Testing
swift test --filter testExcludeFromBackupMarksDirectoryAndLeavesSiblingAlonepassed. The test sets the exclusion twice, writes a file inside the excluded directory, and checks that a siblingvolumes/directory is left alone.