Repository navigation
Call validate() only once when parsing via ParsableArguments.parse(_:) - #983
Merged
Merged
Conversation
The implementation of this parsing point was re-calling the validate() method after parsing had completed, but validate() was already called within the parsing. This eliminates the extra call and adds a test to verify that validate() is only being called once regardless of entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of this parsing point was re-calling the
validate()method after parsing had completed, butvalidate()was already called within the parsing. This eliminates the extra call and adds a test to verify thatvalidate()is only being called once regardless of entry point.Checklist