Repository navigation
Use visibility.base for .longWithSingleDash help names - #985
Open
aniketatgithub wants to merge 1 commit into
Open
aniketatgithub wants to merge 1 commit into
aniketatgithub wants to merge 1 commit into
Conversation
Signed-off-by: Aniket <aniketkomailkro@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #901.
In
NameSpecification.generateHelpNames(visibility:), the.longWithSingleDashcase interpolated the wholevisibilitystruct instead ofvisibility.baselike the.longcase does. SinceArgumentVisibilityhas noCustomStringConvertible, a non-default visibility help flag with single-dash long names came out as e.g.-show-help-ArgumentVisibility(base: hidden)instead of-show-help-hidden.One-line fix: use
visibility.basein the.longWithSingleDashcase, matching.long. AddedsingleDashCustomHelpNamesUseVisibilityBase, which fails before the fix (produces the struct-dump name) and passes after.Checklist