Repository navigation
Fail on duplicate subcommand names or aliases - #993
Open
awaisdev5765 wants to merge 1 commit into
Open
awaisdev5765 wants to merge 1 commit into
awaisdev5765 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #976
Problem
Duplicate subcommand names were silently ignored:
firstChild(withName:)resolves to the first match, so with two subcommands sharing acommandName, only the first was invokable while the second remained listed in--helpbut could never run. This is the behavior reported in #976.Fix
Tree.init(root:)now throws a newInitializationError.duplicateSubcommandwhen a sibling subcommand's name (or alias) collides with an already-registered name/alias at that level.CommandParser.initcatches it viaconfigurationFailure, following the established pattern forrecursiveSubcommandandaliasMatchingCommand.The check also catches alias collisions across sibling subcommands, which would otherwise shadow each other in the same way.
Example failure:
Testing
initializationWithDuplicateSubcommands: two subcommands named "duplicate" → throws (the issue's exact scenario)initializationWithConflictingAliases: two subcommands sharing an alias → throwsinitializationWithDistinctSubcommandsSucceeds: distinct name and alias → no false positive