Skip to content

fix(web): declare a Node floor the lint toolchain can actually run on #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChiragAgg5k wants to merge 1 commit into from
+2 −2
Closed

fix(web): declare a Node floor the lint toolchain can actually run on #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/react-native/package.json.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"analyse": "tsc --noEmit"
},
"engines": {
"node": ">=18.0.0"
"node": "^20.19.0 || ^22.13.0 || >=24"
},
"devDependencies": {
"@eslint/js": "10.0.1",
Expand Down
2 changes: 1 addition & 1 deletion templates/web/package.json.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"analyse": "tsc --noEmit"
},
"engines": {
"node": ">=18.0.0"
"node": "^20.19.0 || ^22.13.0 || >=24"

@greptile-apps greptile-apps Bot Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Consumer Node Support Regresses

These templates produce published SDK packages, so engines.node constrains downstream consumers as well as contributors. A consumer using the still-documented Node 18 runtime with engine-strict will now have installation rejected, even though the incompatible ESLint packages are development-only and absent from consumer installs. The same change appears in templates/react-native/package.json.twig:37, where Node 18 is also still documented as supported.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: templates/web/package.json.twig
Line: 37

Comment:
**Consumer Node Support Regresses**

These templates produce published SDK packages, so `engines.node` constrains downstream consumers as well as contributors. A consumer using the still-documented Node 18 runtime with `engine-strict` will now have installation rejected, even though the incompatible ESLint packages are development-only and absent from consumer installs. The same change appears in `templates/react-native/package.json.twig:37`, where Node 18 is also still documented as supported.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@greptile-apps greptile-apps Bot Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Generated Engine Metadata Conflicts

The matching Web package-lock template still records the root package engine as >=18.0.0, while this generated package manifest now requires ^20.19.0 || ^22.13.0 || >=24. The React Native templates have the same mismatch. Newly generated repositories will therefore contain contradictory Node requirements, and routine lockfile regeneration may produce unexplained repository changes.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: templates/web/package.json.twig
Line: 37

Comment:
**Generated Engine Metadata Conflicts**

The matching Web package-lock template still records the root package engine as `>=18.0.0`, while this generated package manifest now requires `^20.19.0 || ^22.13.0 || >=24`. The React Native templates have the same mismatch. Newly generated repositories will therefore contain contradictory Node requirements, and routine lockfile regeneration may produce unexplained repository changes.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

},
"dependencies": {
"json-bigint": "1.0.0"
Expand Down
Loading