Repository navigation
🔧 fix: Keep LIBRECHAT_* placeholders out of customUserVars substitution - #97
Merged
Merged
Conversation
LIBRECHAT_USER_*, LIBRECHAT_OPENID_* and LIBRECHAT_BODY_* placeholders are resolved from the authenticated user and request. Skip customUserVars whose names use the LIBRECHAT_ prefix so they always resolve from those sources. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIBRECHAT_USER_*,LIBRECHAT_OPENID_*andLIBRECHAT_BODY_*placeholders now always resolve from the logged-in user and the request. StoredcustomUserVarswhose names start withLIBRECHAT_are skipped during substitution.Needed before tenants put
{{LIBRECHAT_USER_EMAIL}}in MCP server headers (MS / msund central MCP server, GENAI-929).Changes
packages/api/src/utils/env.ts: skipLIBRECHAT_*names in thecustomUserVarspass ofprocessSingleValue.env.spec.tsandmcp/__tests__/auth.test.ts. Two existing tests that asserted the old precedence ("prioritize customUserVars over user fields… though not recommended") are updated to the new precedence.Testing
npx jest src/utils/env.spec.ts src/mcp/__tests__/auth.test.ts src/mcp/__tests__/mcp.spec.ts: 210 passed. Without theenv.tschange: 5 failed.npx jest src/utils src/mcpbefore and after: no test went from passing to failing.🤖 Generated with Claude Code