Repository navigation
Handle String::toInt overflow consistently - #283
Open
Firat17aze wants to merge 1 commit into
Open
Firat17aze wants to merge 1 commit into
Firat17aze wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String::toInt()delegates toatol(), whose behavior is undefined when the input is outside the range oflong. As a result, oversized values can produce different results across Arduino platforms. This fixes #175.The conversion now accumulates decimal digits with explicit bounds checks. It returns 0 before overflow, accepts the exact
LONG_MINandLONG_MAXboundaries, preserves the existing leading-whitespace, sign, and trailing-text behavior, and avoids relying on globalerrnostate.Validation:
String::toInt()tests: 12 assertions in 7 test cases passed.api/String.cppfor ATmega328P with-Os -Wall -Wextra -Werror.git diff --checkpassed.No hardware testing was performed; this is a conversion-only change covered by host tests and AVR compilation.
LLMs were used for review and code generation in some parts of this pull request.