Repository navigation
Conversation
Closes arflexx#74 Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@eulami Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
dark-sarge
requested changes
Aug 28, 2026
dark-sarge
left a comment
dark-sarge
left a comment
Contributor
There was a problem hiding this comment.
please resolve all conflicts
Author
|
Conflicts resolved |
Author
|
Hello. Is there a reason why this issue isn't closed yet? Kindy respond. |
The earlier "Merge branch 'main'" commits resolved every conflict by keeping the branch side, so the PR silently dropped main's work (auth revoke/recovery endpoints, referrals/rates/kyc/analytics mounts, admin trade/user endpoints, profile referral fields, assertEnvValid startup validation, several test env shims) and left broken code behind (duplicate initJobQueue import, stray closing brace, duplicate kycStatus key) — that is what `tsc --noEmit` was failing on. Re-apply the issue arflexx#74 work on top of current main instead: - GET /api/v1/profile returns role, kycStatus and virtualAccountNumber - PATCH /api/v1/profile (alias / notificationsEnabled, zod-validated) - GET /api/v1/profile/trades paginated with ?status validation - PATCH /api/v1/admin/users/:id/kyc (admin only) + OpenAPI docs - profile/KYC migration and endpoint tests, merged with main's tests Also fix two pre-existing main breakages that block the server gates: - export @airflex/shared/units from the package exports map (introduced in fd80d00 but never exported, so 12 suites could not resolve it) - use the named `pool` export in trade-lifecycle.test.ts Verified: pnpm --filter airflex-server lint passes; 25/29 suites and 202/209 tests pass — the remaining suites fail on main too or need a live database. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Summary
Verification
pnpm --filter airflex-server lintpnpm --filter airflex-server test