Repository navigation
trusted-fork-NeethuESim/pr-236-fe2be51b1787af94594e2ffb9721891e66a511e8 - #238
Closed
arm-mcp-build[bot] wants to merge 3 commits into
Closed
arm-mcp-build[bot] wants to merge 3 commits into
arm-mcp-build[bot] wants to merge 3 commits into
Conversation
This was referenced Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pre-promotion prerequisite must exclude Black Duck, which intentionally fails on source fork PRs.
1 open issue
What changed in this PR
Updates fork-promotion documentation as part of testing the trusted-fork Black Duck process.
Changes:
- Documents the manual-promotion notice for untrusted forks.
- Adds maintainer instructions for promotion using a PR number and reviewed SHA.
| File | Description |
|---|---|
| docs/fork-pr-promotion.md | Expands the manual fork-promotion process instructions. |
Review effort: Balanced
| fails intentionally and directs reviewers to use the promoted internal pull | ||
| request. | ||
| - For untrusted forked PR, promote workflow will be successful however following message will be displayed in the workflow logs - `Manual fork promotion required, Pull request ## must be reviewed and promoted with the manual workflow.` | ||
| - Post code review and ensuring all the required workflows work, Maintainer now has to run the promote workflow manually using workflow_dispatch by providing the PR ## and reviewed SHA (can be obtained from the reviewed commit). |
Contributor
Author
|
Superseded by #240. Do not merge this older revision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the exact revision from a fork pull request into an internal branch.
NeethuESim/mcpfe2be51b1787af94594e2ffb9721891e66a511e8auto@NeethuESimAfter this internal pull request merges, close the original pull request manually.
The required Black Duck guard accepts this branch only while its head remains at the reviewed commit. A changed fork head requires a new promotion.