Skip to content

iPhone Summary: end with the project's automations, as web does - #2277

Merged
Luseefor merged 8 commits into
mainfrom
ace/ios-1576-desktop-catchup
Nov 20, 2026
Merged

Luseefor merged 8 commits into
mainfrom
ace/ios-1576-desktop-catchup

Conversation

@Luseefor

@Luseefor Luseefor commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

The web Summary ends with one quiet line for the project's schedules ("2 automations in this project · next tonight 2:00 AM") that opens Automations. The iPhone Summary had none. This is the last item of #1576 that main still lacked. The other items there (Inbox · Snoozed · Settled tabs, Sent by, markdown bubbles, compaction, the Summary's sections, remote children, devices and storage copy) are already on main from #2012, #2168, #2165 and earlier iPhone PRs.

  • The line's words moved from the web component into ui-core (projectSchedules, projectAutomationsLine), so web and the bridge share them.
  • With automations off on the machine, the line now reads "1 automation in this project · Automations are off on this machine." instead of web's old "next automations are off on this machine."
  • The bridge answers a new automations.projectLine request. The Summary view now carries the project's folder, because older automations name the folder rather than the project id.
  • Swift only draws the line. One view-scoped task does the first read, the 30 s poll, the re-read on reconnect and Retry (Retry bumps the task's key, so no second reader). Any failed read, including one that never reached the bridge, shows the retry row; a cancelled read stays quiet. The line wraps, so "Automations are off on this machine" is never cut off. Opening it shows Automations in a sheet. The line sits in a stack rather than a Group. A Group passes its modifiers to its children, and before the first reply it has none, so the read never started. The simulator run caught that.

Screenshots

The thread Summary in the spike fixture, iPhone 17 Pro on iOS 26.1.

Before (main) After
Light
Dark

After the review fixes, iPhone 18 Pro Max on iOS 27.0, where the line now wraps:

Verification

  • packages/ui-core/src/automations/project-line.test.ts and two bridge tests in apps/ios/bridge/automations.test.ts cover the count, the next start, folder and id matching, a project with none, and automations turned off.
  • AutomationsUITests.testTheSummaryEndsWithTheProjectsSchedulesAndOpensAutomations opens a thread's Summary in the spike fixture, checks the line, and taps through to Automations. It passes in dark and light. On main it fails with "the Summary shows no automations line", and it failed the same way on this branch until the stack fix.
  • Local checks after merging main: fmt:check, lint, typecheck, check:size and the Swift typecheck of the Ace and AceUITests targets pass. test:changed passes apart from 5 tests in apps/web/src/features/settings/ace-account.test.tsx, which fail the same way on a clean origin/main.

Closes #1576

Model: Claude Opus 5.5

Luseefor and others added 6 commits November 17, 2026 20:34
The web Summary built its "N automations in this project · next …"
line in the component, so the iPhone couldn't share it. It now lives
in ui-core as projectSchedules and projectAutomationsLine. With
automations off on the machine, the line says so instead of reading
"next automations are off on this machine."

Co-Authored-By: spade <bot@acehq.dev>
automations.projectLine reads the person's schedules for a project,
by id or folder, and words them with ui-core's line. The Summary view
now carries the project's folder so older automations still match.
Part of #1576.

Co-Authored-By: spade <bot@acehq.dev>
The web Summary ends with one quiet line for the project's schedules,
opening Automations. The iPhone's had none. It now draws the bridge's
line, and a failed read offers to try again. Part of #1576.

Co-Authored-By: spade <bot@acehq.dev>
Co-Authored-By: spade <bot@acehq.dev>
Luseefor added a commit that referenced this pull request Nov 20, 2026
Co-Authored-By: spade <bot@acehq.dev>
The line sat in a Group, and a Group hands its modifiers to its children. Before the first reply it has none, so the .task that reads the line never ran and the line never showed. A stack is one view even when empty, so the read starts when the page opens. AutomationsUITests' Summary test failed without this and passes with it.

Co-Authored-By: spade <bot@acehq.dev>
@Luseefor
Luseefor marked this pull request as ready for review November 20, 2026 00:09
…ailed read, and a line that wraps

Retry started a task of its own, which could outlive the Summary or overlap the half-minute poll. It now bumps a counter in the .task(id:) key, so the first read, the poll and Retry share one view-scoped loop.

A read that never reached the bridge (a timeout, say) left the foot blank with nothing to tap. It now shows the same retry row as a read the bridge reports as failed. A read cancelled by leaving the page or by a newer read stays quiet.

The line was held to one line and could cut off its end, which is where 'Automations are off on this machine' sits. It now wraps.

Co-Authored-By: spade <bot@acehq.dev>
Luseefor added a commit that referenced this pull request Nov 20, 2026
Co-Authored-By: spade <bot@acehq.dev>
@Luseefor
Luseefor merged commit 249185f into main Nov 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS: catch up with the 2026-11-01 desktop changes (Inbox tabs, Sent by, Summary, markdown bubbles)

1 participant