Repository navigation
iPhone Summary: end with the project's automations, as web does - #2277
Merged
Merged
Conversation
The web Summary built its "N automations in this project · next …" line in the component, so the iPhone couldn't share it. It now lives in ui-core as projectSchedules and projectAutomationsLine. With automations off on the machine, the line says so instead of reading "next automations are off on this machine." Co-Authored-By: spade <bot@acehq.dev>
automations.projectLine reads the person's schedules for a project, by id or folder, and words them with ui-core's line. The Summary view now carries the project's folder so older automations still match. Part of #1576. Co-Authored-By: spade <bot@acehq.dev>
The web Summary ends with one quiet line for the project's schedules, opening Automations. The iPhone's had none. It now draws the bridge's line, and a failed read offers to try again. Part of #1576. Co-Authored-By: spade <bot@acehq.dev>
Co-Authored-By: spade <bot@acehq.dev>
Co-Authored-By: spade <bot@acehq.dev>
Co-Authored-By: spade <bot@acehq.dev>
Luseefor
added a commit
that referenced
this pull request
Nov 20, 2026
Co-Authored-By: spade <bot@acehq.dev>
The line sat in a Group, and a Group hands its modifiers to its children. Before the first reply it has none, so the .task that reads the line never ran and the line never showed. A stack is one view even when empty, so the read starts when the page opens. AutomationsUITests' Summary test failed without this and passes with it. Co-Authored-By: spade <bot@acehq.dev>
Luseefor
marked this pull request as ready for review
November 20, 2026 00:09
…ailed read, and a line that wraps Retry started a task of its own, which could outlive the Summary or overlap the half-minute poll. It now bumps a counter in the .task(id:) key, so the first read, the poll and Retry share one view-scoped loop. A read that never reached the bridge (a timeout, say) left the foot blank with nothing to tap. It now shows the same retry row as a read the bridge reports as failed. A read cancelled by leaving the page or by a newer read stays quiet. The line was held to one line and could cut off its end, which is where 'Automations are off on this machine' sits. It now wraps. Co-Authored-By: spade <bot@acehq.dev>
Luseefor
added a commit
that referenced
this pull request
Nov 20, 2026
Co-Authored-By: spade <bot@acehq.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web Summary ends with one quiet line for the project's schedules ("2 automations in this project · next tonight 2:00 AM") that opens Automations. The iPhone Summary had none. This is the last item of #1576 that main still lacked. The other items there (Inbox · Snoozed · Settled tabs, Sent by, markdown bubbles, compaction, the Summary's sections, remote children, devices and storage copy) are already on main from #2012, #2168, #2165 and earlier iPhone PRs.
projectSchedules,projectAutomationsLine), so web and the bridge share them.automations.projectLinerequest. The Summary view now carries the project's folder, because older automations name the folder rather than the project id.Group. AGrouppasses its modifiers to its children, and before the first reply it has none, so the read never started. The simulator run caught that.Screenshots
The thread Summary in the spike fixture, iPhone 17 Pro on iOS 26.1.
After the review fixes, iPhone 18 Pro Max on iOS 27.0, where the line now wraps:
Verification
packages/ui-core/src/automations/project-line.test.tsand two bridge tests inapps/ios/bridge/automations.test.tscover the count, the next start, folder and id matching, a project with none, and automations turned off.AutomationsUITests.testTheSummaryEndsWithTheProjectsSchedulesAndOpensAutomationsopens a thread's Summary in the spike fixture, checks the line, and taps through to Automations. It passes in dark and light. On main it fails with "the Summary shows no automations line", and it failed the same way on this branch until the stack fix.fmt:check,lint,typecheck,check:sizeand the Swift typecheck of the Ace and AceUITests targets pass.test:changedpasses apart from 5 tests inapps/web/src/features/settings/ace-account.test.tsx, which fail the same way on a clean origin/main.Closes #1576
Model: Claude Opus 5.5