Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The guide and
dehumanize()docstring show April 20 plus “in a month” becoming May 18. The implementation applies a calendar-month shift, so the shown result should be May 20; the guide's Hindi example has the same incorrect result.Correct all three month results and construct the same fixed April 20 timestamp in these examples so the displayed inputs and outputs are reproducible. The two-days-ago examples remain April 18. This changes documentation only, including the docstring; it leaves the parameter-name correction in #1355 untouched.
Validation: followed English/Hindi locale matching through
dehumanize()toshift(months=1), read the existing shift assertions, and confirmed by AST comparison that all executable Python is identical after excluding the changed docstring. Source bytes and the final diff were checked. No Arrow/dateutil imports, dependency installs, project tests or documentation build were run locally. This is a draft pending those checks.AI assistance: prepared with OpenAI Codex, with source and diff review.
Pull Request Checklist
masterat2224255c4acc594d734cef0bbc83360452a67983.